Open
Conversation
h3adex
changed the title
h3adex
force-pushed
the
feat/iaas-add-routes-command
branch
from
761c6d9 to
e82d1cc
Compare
Member
|
blocked by #1339 |
h3adex
force-pushed
the
feat/iaas-add-routes-command
branch
4 times, most recently
from
148b51b to
c16fd34
Compare
Contributor
Author
|
ready for review |
h3adex
force-pushed
the
feat/iaas-add-routes-command
branch
from
c16fd34 to
9a6e375
Compare
h3adex
force-pushed
the
feat/iaas-add-routes-command
branch
from
9a6e375 to
1726436
Compare
marceljk
reviewed
Mar 19, 2026
Comment on lines
+62
to
+65
| `stackit network-area routing-table route create \ | ||
| --routing-table-id xxx --organization-id yyy --network-area-id zzz \ | ||
| --destination-type cidrv4 --destination-value <ipv4-cidr> \ | ||
| --nexthop-type ipv4 --nexthop-value <ipv4-address>`), |
Contributor
There was a problem hiding this comment.
Can you make oneliner out of the example commands? And add a dollar sign as prefix, to indicate this is a command and stay consistent with the other examples.
Suggested change
| `stackit network-area routing-table route create \ | |
| --routing-table-id xxx --organization-id yyy --network-area-id zzz \ | |
| --destination-type cidrv4 --destination-value <ipv4-cidr> \ | |
| --nexthop-type ipv4 --nexthop-value <ipv4-address>`), | |
| `$ stackit network-area routing-table route create --routing-table-id xxx --organization-id yyy --network-area-id zzz --destination-type cidrv4 --destination-value <ipv4-cidr> --nexthop-type ipv4 --nexthop-value <ipv4-address>`), |
Adjust also the other examples
Comment on lines
+57
to
+59
|
|
||
| prompt := fmt.Sprintf("Are you sure you want to delete the route %q in routing-table %q for network area id %q?", model.RouteID, model.RoutingTableId, model.NetworkAreaId) | ||
| err = params.Printer.PromptForConfirmation(prompt) |
Contributor
There was a problem hiding this comment.
Here you can use as well the utils function, which gets the routing-table name instead of the ID
Comment on lines
+61
to
+62
|
|
||
| prompt := fmt.Sprintf("Are you sure you want to update route %q for routing-table with id %q?", model.RouteId, model.RoutingTableId) |
marceljk
reviewed
Mar 19, 2026
Comment on lines
+90
to
+91
|
|
||
| prompt := fmt.Sprintf("Are you sure you want to create a route for routing-table with id %q?", model.RoutingTableId) |
Contributor
There was a problem hiding this comment.
Same here
stackit-cli/internal/cmd/network-area/routingtable/update/update.go
Lines 84 to 92 in ef5172c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for routing-table routes. Waits for #1339
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)